Jgarber RedCloth → 4.1.9

Comments and changes to this ticket

• You flagged this item as spam.
  

  Greg Moreno November 5th, 2008 @ 08:08 PM

  Nevermind. RedCloth doc says that link should be surrounded by brackets in cases like this.

• 

  Jason Garber January 20th, 2009 @ 04:52 PM

  • Milestone set to “4.1.9”
  • State changed from “new” to “open”
  • Title changed from “Rendering error for link with parenthesis” to “Handle containing parentheses”

  Glad you figured it out, Greg. Your case adds weight to Ryan Alyea's assertion:

  Is there a better way to support parenthesis in links like Wikipedia links? Requiring brackets around the link is confusing to many new users who don't understand why their Wikipedia links won't work. I wrote a patch on the latest version of RedCloth to support this a lot better. Instead of stopping on a end parenthesis, it instead looks at the URL itself. If the number of opening and closing parenthesis are equal, it allows the end parenthesis in the link. I'm sure there's a better way, like checking if they are properly nested.

  Best of all, he included a patch! Hopefully it'll work out and you won't have to use brackets.

  • links_containing_parenthesis.patch 1.3 KB
• 

  Jason Garber January 20th, 2009 @ 04:53 PM

  And his tests.

  • tests_for_links_containing_parenthesis.patch 1.9 KB
• 

  Jason Garber January 20th, 2009 @ 04:55 PM

  • Title changed from “Handle containing parentheses” to “Handle links containing parentheses”
• 

  Jason Garber January 21st, 2009 @ 05:04 PM

  • State changed from “open” to “resolved”

  (from [9d57475caaddf23decebc6ddb3fe5625e6db5f71]) Handle links containing parentheses. Brackets are no longer required. [#82 state:resolved] http://github.com/jgarber/redclo...