
Another subtle link-inside-quotes misbehaviour
Reported by Steve Purcell | October 1st, 2008 @ 03:57 AM | in 4.0.4
Hi Jason,
Here's another subtle case where links inside quotes aren't quite rendered correctly. The ” before "said Gore" comes out as " with the current RedCloth code from github.
diff --git a/test/links.yml b/test/links.yml
index 122e1ed..417910f 100644
--- a/test/links.yml
+++ b/test/links.yml
@@ -251,3 +251,9 @@ in: |-
html: |-
<p>“Here is a <a href="http://redcloth.org/">link</a>.</p>
<p>“I like links.”</p>
+---
+name: contained in para with multiple quotes
+in: |-
+ "My wife, Tipper, and I will donate 100% of the proceeds of the award to the "Alliance For Climate Protection":http://www.looktothestars.org/charity/638-alliance-for-climate-protection," said Gore in an email. "I am deeply honored to receive the Nobel Peace Prize."
+html: |-
+ <p>“My wife, Tipper, and I will donate 100% of the proceeds of the award to the <a href="http://www.looktothestars.org/charity/638-alliance-for-climate-protection">Alliance For Climate Protection</a>,” said Gore in an email. “I am deeply honored to receive the Nobel Peace Prize.”
Comments and changes to this ticket
-
Jason Garber October 1st, 2008 @ 11:07 AM
- State changed from new to open
Good catch! Even Textile 2 gets it wrong (in the same way as RedCloth currently - see http://textile.thresholdstate.com/
I'll fix it.
-
Jason Garber October 1st, 2008 @ 11:11 AM
- State changed from open to resolved
(from [d543c7bfce022622455adcb09e30c3f1fbddb92b]) Fixed incorrect handling of links inside double quotations.
[#63 state:resolved] http://github.com/jgarber/redclo...
-
Jason Garber October 1st, 2008 @ 11:50 AM
I think it's great that you're using it so heavily and providing all these bug reports! And yes, I plan to release 4.0.4 today!
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
RedCloth is a Ruby library for converting Textile into HTML
People watching this ticket
Referenced by
-
63 Another subtle link-inside-quotes misbehaviour [#63 state:resolved] http://github.com/jgarber/redclo...