#59 ✓resolved
Steve Purcell

Links not recognized inside multi-paragraph quotes

Reported by Steve Purcell | September 24th, 2008 @ 04:27 PM | in 4.0.4

In a quotation that spans two paragraphs, it's usual to omit the closing quote of the first paragraph. Doing so, however, apparently stops Redcloth from detecting and rendering links inside that first para.

And putting a notextile section inside that first para makes a real mess.

Here's what I've added to test/links.yml to demonstrate the issue:

name: link contained in multi-paragraph quote
in: |-
  "I first learned about "Redcloth":http://redcloth.org/ several years ago.

  "It's wonderful."
html: |-
  <p>&#8220;I first learned about <a href="http://redcloth.org/">Redcloth</a> several years ago.</p>
  <p>&#8220;It&#8217s wonderful.&#8221;</p>
name: html contained in multi-paragraph quote
in: |-
  "Here is a <notextile><a href="http://redcloth.org/">link</a></notextile>.

  "I like links."
html: |-
  <p>&#8220;Here is a <a href="http://redcloth.org/">link</a>.</p>
  <p>&#8220;I like links..&#8221;</p>

Comments and changes to this ticket

  • Steve Purcell

    Steve Purcell September 24th, 2008 @ 04:30 PM

    Oh, and here's the problem "in the wild" -- see the second paragraph here:


    I'm afraid I don't know where to start to help fix this...

  • Jason Garber

    Jason Garber September 25th, 2008 @ 01:28 PM

    • State changed from “new” to “resolved”

    (from [7e3665dcdd7a2e4ae494daf602f180a2e38e6876]) Allow a paragraph to start with a quotation mark but omit it at the end to continue the quotation without messing up links.

    A blockquote ought to be used in this case, IMHO, but since Textile 2 supports it, we should too. [#59 state:resolved] http://github.com/jgarber/redclo...

  • Jason Garber

    Jason Garber September 25th, 2008 @ 01:29 PM

    I really think you should be using blockquotes for this purpose, and then giving it quotes with CSS, but since Textile 2 supports it, we will too.

  • Steve Purcell

    Steve Purcell September 26th, 2008 @ 03:46 AM

    Awesome, Jason -- you rock!

    BTW, strangely, I think this used to work with Redcloth 3, and only later did. It'll be nice to see our old stories start rendering correctly again.

    I'm not entirely convinced that bq should be used in this case; it makes sense to me that idiomatic english prose should always render correctly without such hints, even if a link or other span-oriented piece of markup is contained with in it. I guess I'm used to the pattern of using specially-styled blockquotes to insert fancy "call-out" quotations in a longer block of text...

    Anyway - thanks again!

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

RedCloth is a Ruby library for converting Textile into HTML

Shared Ticket Bins

People watching this ticket

Referenced by