<notextile> blocks included in following paragrap
Reported by Michael Granger | March 9th, 2009 @ 09:34 AM | in 4.2.0
Somewhere between 4.1.1 and 4.1.9, stopped working:
$ cat notextile_example.textile
Some text:
<notextile>
<div class="example"><pre>
Some code
</pre></div>
</notextile>
Some more text.
$ redcloth _4.1.1_ notextile_example.textile
<p>Some text:</p>
<div class="example"><pre>
Some code
</pre></div><p>Some more text.</p>
$ redcloth _4.1.9_ notextile_example.textile
<p>Some text:</p>
<p><div class="example"><pre><br />
Some code<br />
</pre></div><br />
<br />
Some more text.</p>
It looks like it's including the following paragraph instead of just including what was in the block as-is. Maybe this is related to the fix for #81?
Also, the description of how is supposed to work in the reference is a bit broken. The source doesn't have a closing , and the output has the text that was inside the '==' inline-style notextile span as having been processed anyway.
Comments and changes to this ticket
-
Michael Granger March 9th, 2009 @ 09:38 AM
Awesome. Apparently the formatter is stripping 'notextile' tags, so the above should read: "Somewhere between 4.1.1 and 4.1.9, «notextile» stopped working"
and...
"Also, the description of how «notextile» is supposed to work..."
and...
"The source doesn't have a closing «/notextile»..."
Sorry 'bout that. I dearly wish lighthouse had a preview for ticket creation. Or for adding comments, come to think of it. I only hope this will render as expected.
-
Jason Garber March 12th, 2009 @ 12:08 PM
Yup. Definitely a problem. The bug is also exposed on http://redcloth.org/textile/html...
<notextile> Don't touch this! </notextile> Use ==*asterisks*== to say something *strongly*.renders as
<p>Don’t touch this!<br /> <br /> Use *asterisks* to say something <strong>strongly</strong>.</p> -
Jason Garber March 17th, 2009 @ 04:43 AM
- Milestone set to “4.2.0”
- Tag set to “notextile”
- State changed from “new” to “open”
-
Jason Garber May 26th, 2009 @ 11:36 PM
- State changed from “open” to “resolved”
(from [200b4596fb82ae41c4badfc9f3a5950f84eab7a2]) Fix blocks being included in following paragraph. [#119 state:resolved] http://github.com/jgarber/redcloth/commit/200b4596fb82ae41c4badfc9f...
-
Jason Garber May 26th, 2009 @ 11:37 PM
Ugh. What a nasty regression! The problem was I was appending to block, not html, so it was carried through to whatever followed (in this case the block was a paragraph). I added your test case, so we won't experience that particular regression again.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
RedCloth is a Ruby library for converting Textile into HTML
People watching this ticket
Jason Garber
Michael Granger
Tags
Referenced by
-
112
Blank lines after </notextile> produce <br>s
Might be a duplicate of #119 - not sure
-
119
<notextile> blocks included in following paragrap
(from [200b4596fb82ae41c4badfc9f3a5950f84eab7a2])
Fix blo...
-
112
Blank lines after </notextile> produce <br>s
Yes, it was a duplicate of #119. It's fixed now.
-
112
Blank lines after </notextile> produce <br>s
Yes, it was a duplicate of #119. It's fixed now.
-
112
Blank lines after </notextile> produce <br>s
Yes, it was a duplicate of #119. It's fixed now.